getFrog

Stupid question, but what happens to a rejected PR? Because features get built for a reason (there’s usually a Ticket/Story for the feature that the PR adds) so do those just get closed? Or does the person have to re-write the code entirely?

I know in my team, the most I could do is tell the coworker to self-review while keeping the PR open until they change some stuff. I have never rejected a PR before because no matter how bad a PR is, it always is technically necessary for the feature.

Like, if I’m doing something for myself, that’s exactly the place where I wanna do something amazing,

That’s always my intention with my personal projects too! But that always results in “Wow I just learned how to do this thing much better, let me refactor the whole project to do it perfectly everywhere” followed by my Adderall running out. So there’s just so many half-done refactors I either forget about or abandon because I get a new idea the next day, but that’s totally just a skill issue.

You’re right though, the code I write at work is much worse, but my Company hosts their own GitLab instance so the code we write can’t even be used to poison Copilot :(

you literally have access to all the code in the world

I’d like to believe that they were honorable enough to not secretly train on code without people’s permission. But realistically they totally did exactly that, but just made the AI Model this incompetent through some other engineering blunder.

Also, random side thought - training only on public repos probably yields you way higher code quality as opposed to training on both public and private repos? I assume we all have some very messy private repos that we’re too embarrassed to publish because the code quality is absolute shit … right?

Nope, no other reason! I’m just getting a decent deal on PC parts when I let my employer buy them for me so I have a tendency to splurge on tech without really double-checking the specs. Can’t justify that with the current RAM prices though haha

But thanks for the tip! I’ll keep it in mind when I do actually decide to upgrade sometime

I built my first PC last November and because RAM was about 2-3 times the price that it should have been I passed on it. Now it’s like 5x the price and it’s not even a choice anymore, but I think I still made the right decision by not financially supporting those prices. Got 16GB of second hand SODIMM and some Sodimm to Dimm adapters and honestly the PC is fine. In my original parts list I had planned to get 128GB just to max out the board and not think about it ever again (would have been a reasonable 550€ back in September) but now I think I’ll actually coast a bit longer with my 16GB. It should be fine for the next few years at least, especially since there’s no overhead from Windows BS on my machine.

Print that header onto the dial in a monospace font and you’ve got yourself an extremely marketable product. Perfect thing to bring to a white elephant gift exchange at an IT Company!